Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Responding to audits #61

Closed
wants to merge 13 commits into from
Closed

Responding to audits #61

wants to merge 13 commits into from

Conversation

yoshidan
Copy link
Contributor

@yoshidan yoshidan commented Nov 9, 2024

If the voters for a finalized header are untrusted, 1/3+ of the voters must be included in the trusted validator set.

Naohiro Yoshida added 12 commits November 8, 2024 13:35
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
@yoshidan yoshidan marked this pull request as ready for review November 10, 2024 04:45

// Ensure voters for grand child are valid
verify_voters(
&last_voters,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only check for grand child header.

@yoshidan yoshidan requested review from 3100 and removed request for 3100 November 10, 2024 10:54
@yoshidan yoshidan marked this pull request as draft November 12, 2024 10:33
@yoshidan yoshidan closed this Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant